-
Notifications
You must be signed in to change notification settings - Fork 9
Additional format() testing #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional format() testing #98
Conversation
|
An automated preview of the documentation is available at https://98.beast2.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-12-10 16:06:12 UTC |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 39.87% 41.43% +1.55%
===========================================
Files 35 35
Lines 1244 1272 +28
===========================================
+ Hits 496 527 +31
+ Misses 748 745 -3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
GCOVR code coverage report https://98.beast2.prtest3.cppalliance.org/gcovr/index.html Build time: 2025-12-10 16:11:48 UTC |
|
if there is already full coverage then we can close this? |
include/boost/beast2/format.hpp
Outdated
| p0 = p; | ||
| return seg; | ||
| } | ||
| throw std::runtime_error("invalid format string, unmatched }"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems kind of harsh... throwing? Anyway if we are going to throw we need to use the helpers in detail/except.hpp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwing is consistent with the behaviour of both fmtlib and std::format. Code that works with this implementation therefore has a clear migration path in the future.
Will change to use the helpers.
|
lets make sure we squash this down and have correct grammar in the commit message please |
a39a692 to
56c6b2c
Compare
56c6b2c to
4c1170c
Compare
No description provided.