remove duplicated condition

ranges is empty if lines_changed_only is Off

Author: 2bndy5

cpp-linter/src/clang_tools/clang_tidy.rs

@@ -17,7 +17,7 @@ use tokio::process::Command;
 // project-specific modules/crates
 use super::MakeSuggestions;
 use crate::{
-    cli::{ClangParams, LinesChangedOnly},
+    cli::ClangParams,
     common_fs::{normalize_path, FileObj},
 };
 
@@ -269,19 +269,17 @@ pub async fn run_clang_tidy(
         for arg in &clang_params.extra_args {
             args.extend(["--extra-arg".to_string(), format!("\"{}\"", arg)]);
         }
-        if clang_params.lines_changed_only != LinesChangedOnly::Off {
-            let ranges = file.get_ranges(&clang_params.lines_changed_only);
-            if !ranges.is_empty() {
-                let filter = format!(
-                    "[{{\"name\":{:?},\"lines\":{:?}}}]",
-                    &file_name.replace('/', if OS == "windows" { "\\" } else { "/" }),
-                    ranges
-                        .iter()
-                        .map(|r| [r.start(), r.end()])
-                        .collect::<Vec<_>>()
-                );
-                args.extend(["--line-filter".to_string(), filter]);
-            }
+        let ranges = file.get_ranges(&clang_params.lines_changed_only);
+        if !ranges.is_empty() {
+            let filter = format!(
+                "[{{\"name\":{:?},\"lines\":{:?}}}]",
+                &file_name.replace('/', if OS == "windows" { "\\" } else { "/" }),
+                ranges
+                    .iter()
+                    .map(|r| [r.start(), r.end()])
+                    .collect::<Vec<_>>()
+            );
+            args.extend(["--line-filter".to_string(), filter]);
         }
         (file_name, args)
     };