revert use of tokio::fs (back to std::fs)

there was a noticeable performance increase in the benchmarks

Under the hood `tokio::fs` uses more overhead than `std::fs`.
And, the usage here are in synchronous contexts anyway.

Author: 2bndy5

cpp-linter/Cargo.toml

@@ -28,7 +28,7 @@ reqwest = "0.12.24"
 semver = "1.0.27"
 serde = { version = "1.0.228", features = ["derive"] }
 serde_json = "1.0.145"
-tokio = { version = "1.48.0", features = ["macros", "rt-multi-thread", "process", "fs"] }
+tokio = { version = "1.48.0", features = ["macros", "rt-multi-thread", "process"] }
 tokio-macros = "2.5.0"
 tokio-stream = "0.1.17"
 which = "8.0.0"

cpp-linter/src/clang_tools/clang_format.rs

@@ -1,12 +1,15 @@
 //! This module holds functionality specific to running clang-format and parsing it's
 //! output.
 
-use std::sync::{Arc, Mutex};
+use std::{
+    fs,
+    sync::{Arc, Mutex},
+};
 
 use anyhow::{anyhow, Context, Result};
 use log::Level;
 use serde::Deserialize;
-use tokio::{fs, process::Command};
+use tokio::process::Command;
 
 // project-specific crates/modules
 use super::MakeSuggestions;
@@ -155,7 +158,7 @@ pub async fn run_clang_format(
     };
     format_advice.patched = patched;
     if !format_advice.replacements.is_empty() {
-        let original_contents = fs::read(&file_name).await.with_context(|| {
+        let original_contents = fs::read(&file_name).with_context(|| {
             format!(
                 "Failed to read file's original content before translating byte offsets: {file_name}",
             )

cpp-linter/src/clang_tools/clang_tidy.rs

@@ -3,6 +3,7 @@
 
 use std::{
     env::{consts::OS, current_dir},
+    fs,
     path::PathBuf,
     sync::{Arc, Mutex},
 };
@@ -11,7 +12,7 @@ use std::{
 use anyhow::{anyhow, Context, Result};
 use regex::Regex;
 use serde::Deserialize;
-use tokio::{fs, process::Command};
+use tokio::process::Command;
 
 // project-specific modules/crates
 use super::MakeSuggestions;
@@ -288,7 +289,7 @@ pub async fn run_clang_tidy(
         None
     } else {
         args.push("--fix-errors".to_string());
-        Some(fs::read_to_string(&file_name).await.with_context(|| {
+        Some(fs::read_to_string(&file_name).with_context(|| {
             format!(
                 "Failed to cache file's original content before applying clang-tidy changes: {}",
                 file_name.clone()
@@ -336,12 +337,10 @@ pub async fn run_clang_tidy(
         // cache file changes in a buffer and restore the original contents for further analysis
         tidy_advice.patched = Some(
             fs::read(&file_name)
-                .await
                 .with_context(|| format!("Failed to read changes from clang-tidy: {file_name}"))?,
         );
         // original_content is guaranteed to be Some() value at this point
         fs::write(&file_name, original_content.unwrap())
-            .await
             .with_context(|| format!("Failed to restore file's original content: {file_name}"))?;
     }
     {

cpp-linter/src/clang_tools/mod.rs

@@ -4,6 +4,7 @@
 use std::{
     env::current_dir,
     fmt::{self, Display},
+    fs,
     path::{Path, PathBuf},
     sync::{Arc, Mutex},
 };
@@ -13,7 +14,7 @@ use anyhow::{anyhow, Context, Result};
 use git2::{DiffOptions, Patch};
 use regex::Regex;
 use semver::Version;
-use tokio::{fs, process::Command, task::JoinSet};
+use tokio::{process::Command, task::JoinSet};
 use which::{which, which_in};
 
 // project-specific modules/crates
@@ -229,7 +230,7 @@ pub async fn capture_clang_tools_output(
 
     // parse database (if provided) to match filenames when parsing clang-tidy's stdout
     if let Some(db_path) = &clang_params.database {
-        if let Ok(db_str) = fs::read(db_path.join("compile_commands.json")).await {
+        if let Ok(db_str) = fs::read(db_path.join("compile_commands.json")) {
             clang_params.database_json = Some(
                 // A compilation database should be UTF-8 encoded, but file paths are not; use lossy conversion.
                 serde_json::from_str::<Vec<CompilationUnit>>(&String::from_utf8_lossy(&db_str))