AI review suggestions

Author: 2bndy5

cpp-linter/src/clang_tools/mod.rs

@@ -148,8 +148,7 @@ async fn analyze_single_file(
         if clang_params
             .format_filter
             .as_ref()
-            .is_some_and(|f| f.is_source_or_ignored(file_name.as_path()))
-            || clang_params.format_filter.is_none()
+            .is_none_or(|f| f.is_source_or_ignored(file_name.as_path()))
         {
             let format_result = run_clang_format(&file, &clang_params).await?;
             logs.extend(format_result);
@@ -167,8 +166,7 @@ async fn analyze_single_file(
         if clang_params
             .tidy_filter
             .as_ref()
-            .is_some_and(|f| f.is_source_or_ignored(file_name.as_path()))
-            || clang_params.tidy_filter.is_none()
+            .is_none_or(|f| f.is_source_or_ignored(file_name.as_path()))
         {
             let tidy_result = run_clang_tidy(&file, &clang_params).await?;
             logs.extend(tidy_result);
@@ -182,11 +180,11 @@ async fn analyze_single_file(
             ));
         }
     }
-    Ok((file_name.clone(), logs))
+    Ok((file_name, logs))
 }
 
 /// A struct to contain the version numbers of the clang-tools used
-#[derive(Default)]
+#[derive(Debug, Default)]
 pub struct ClangVersions {
     /// The clang-format version used.
     pub format_version: Option<String>,
@@ -200,7 +198,7 @@ pub struct ClangVersions {
 /// If `tidy_checks` is `"-*"` then clang-tidy is not executed.
 /// If `style` is a blank string (`""`), then clang-format is not executed.
 pub async fn capture_clang_tools_output(
-    files: &Vec<Arc<Mutex<FileObj>>>,
+    files: &[Arc<Mutex<FileObj>>],
     version: &RequestedVersion,
     clang_params: &mut ClangParams,
     rest_api_client: &impl RestApiClient,
@@ -241,14 +239,17 @@ pub async fn capture_clang_tools_output(
     };
 
     let mut executors = JoinSet::new();
+    let arc_params = Arc::new(clang_params.clone());
     // iterate over the discovered files and run the clang tools
     for file in files {
-        let arc_params = Arc::new(clang_params.clone());
         let arc_file = Arc::clone(file);
-        executors.spawn(analyze_single_file(arc_file, arc_params));
+        executors.spawn(analyze_single_file(arc_file, arc_params.clone()));
     }
 
     while let Some(output) = executors.join_next().await {
+        // output?? acts as a fast-fail for any error encountered.
+        // This includes any `spawn()` error and any `analyze_single_file(`) Result.
+        // Any unresolved tasks are aborted and dropped when an error is returned here.
         let (file_name, logs) = output??;
         rest_api_client.start_log_group(format!("Analyzing {}", file_name.to_string_lossy()));
         for (level, msg) in logs {