Skip to content

Commit b9b4ec8

Browse files
committed
intentionally ignore tests/demo/demo.hpp
Apparently, there was a bug previously that somehow filtered out demo.hpp for some PR review tests.
1 parent 402d6aa commit b9b4ec8

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

cpp-linter/tests/reviews.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,17 +213,19 @@ async fn setup(lib_root: &Path, test_params: &TestParams) {
213213
);
214214
}
215215

216-
let mut tool_ignore = "**/*.c".to_string();
216+
let mut format_ignore = "**/*.c".to_string();
217+
let mut tidy_ignore = format_ignore.clone();
217218
if test_params.force_lgtm {
218-
tool_ignore.push_str("|**/*.cpp|**/*.h");
219+
format_ignore.push_str("|**/*.cpp|**/*.h");
220+
tidy_ignore.push_str("|**/*.hpp");
219221
}
220222
let mut args = vec![
221223
"cpp-linter".to_string(),
222224
"-v=debug".to_string(),
223225
format!("-V={}", clang_version),
224226
format!("-l={}", test_params.lines_changed_only),
225-
format!("--ignore-tidy={}", tool_ignore),
226-
format!("--ignore-format={}", tool_ignore),
227+
format!("--ignore-tidy={}", tidy_ignore),
228+
format!("--ignore-format={}", format_ignore),
227229
format!("--tidy-review={}", test_params.tidy_review),
228230
format!("--format-review={}", test_params.format_review),
229231
format!("--passive-reviews={}", test_params.passive_reviews),

0 commit comments

Comments
 (0)