Add gauge metric for number of self-hosted org runners#165
Open
peterhalasz wants to merge 2 commits intocpanato:mainfrom
Open
Add gauge metric for number of self-hosted org runners#165peterhalasz wants to merge 2 commits intocpanato:mainfrom
peterhalasz wants to merge 2 commits intocpanato:mainfrom
Conversation
Signed-off-by: Peter Halasz <peter.halasz@live.com>
Signed-off-by: Peter Halasz <peter.halasz@live.com>
cpanato
reviewed
Feb 7, 2024
Owner
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
sgtm, can you show the results of this?
also if we dont set gh.runners-repos this metric will be collected as well?
Owner
|
need a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new metric for the number of self-hosted organization action runners
github_actions_num_self_hosted_org_runnersIt's unclear to me whether reporting the total number of runners is enough by itself. I think the number stays the same even if the registered runners are offline...
Alternatively I could add a few labels to the metric like
name,os,status,busy, etc. (Github API docs)What do you think?