Skip to content

fix: update known issues related to orders with zero amounts #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marshymarsh merged 1 commit into from
May 5, 2026
Merged

fix: update known issues related to orders with zero amounts #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions docs/cow-protocol/reference/contracts/core/README.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,10 @@ The security considerations of upgradeability are discussed in the [GPv2Allowlis

## Security / Known Issues

### Partially fillable orders with zero amounts
### Orders with zero amounts
Copy link
Copy Markdown
Contributor

@anxolin anxolin May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we mention somewhere they must not use any fee too?

Copy link
Copy Markdown
Contributor

@fedgiac fedgiac May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only do so indirectly, for example:

But we also have contradicting documentation:

I agree we should change that, this is not part of this PR however.


If a user creates an order with:
If a user creates an order with `sellAmount = 0` or `buyAmount = 0`, then this order could be executed an arbitrary amount of times instead of just a single time.

* `sellAmount = 0`
* `buyAmount = 0`
* `partiallyFillable = true`

Then this order could be executed an arbitrary amount of times instead of just a single time.
This means that any solver could drain the fee amount from the user until not enough funds are available anymore.

:::tip
Expand Down
Loading