Skip to content

fix: update known issues related to orders with zero amounts #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorroncevic merged 1 commit into from
May 5, 2026
Merged

fix: update known issues related to orders with zero amounts #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,8 @@ A summary of coverage results are printed out to console. More detailed informat

## Known issues

If a user creates an order with:
- zero sell amount
- zero buy amount
- partially fillable set to false
If a user creates an order with `sellAmount = 0` or `buyAmount = 0`, then this order could be executed an arbitrary amount of times instead of just a single time.

then this order could be executed an arbitrary amount of times instead of just a single time.
This means that any solver could drain the fee amount from the user until not enough funds are available anymore.

We recommend to never sign orders of this form and, if developing a contract that creates orders on behalf of other users, make sure at a contract level that such orders cannot be created.
Expand Down
Loading