chore: ci.yml; pre-commit hooks#15
Open
igorroncevic wants to merge 1 commit intomainfrom
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add CI jobs that call
justcommands and local hooks that run the same checks before commits and pushes.Context
This PR depends on the Justfile PR. It is only testable after the previous PRs, including the Justfile and coverage PR, are merged. The workflow uses a composite setup action for checkout, Foundry, and
just. The hooks run fast checks before commits and slower checks before pushes, while CI remains the source of truth.Out of Scope
This PR does not add new lint, Slither, test, or coverage commands. It only wires existing commands into CI and local hooks.
Testing Instructions
python -m venv dev/.venv.dev/.venv/bin/pip install -r dev/requirements.txt.dev/.venv/bin/pre-commit install --hook-type pre-commit --hook-type pre-push.dev/.venv/bin/pre-commit run just-lint --all-files.dev/.venv/bin/pre-commit run just-test --hook-stage pre-push --all-files.dev/.venv/bin/pre-commit run just-slither --hook-stage pre-push --all-files.dev/.venv/bin/pre-commit run just-coverage-check --hook-stage pre-push --all-files.