Skip to content

chore: use catalog for angular dependencies#6991

Merged
louis-bompart merged 6 commits intomainfrom
chore/update-angular-21
Mar 19, 2026
Merged

chore: use catalog for angular dependencies#6991
louis-bompart merged 6 commits intomainfrom
chore/update-angular-21

Conversation

@louis-bompart
Copy link
Copy Markdown
Collaborator

@louis-bompart louis-bompart commented Jan 19, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2026

🔗 Scratch Orgs ready to test this PR:

@louis-bompart louis-bompart changed the title chore: use catalog for angular stuff chore: use catalog for angular dependencies Jan 19, 2026
Base automatically changed from chore/update-typescript to main March 12, 2026 21:23
@secaccount
Copy link
Copy Markdown

secaccount commented Mar 18, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI review requested due to automatic review settings March 18, 2026 20:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Angular-related dependencies across the monorepo to use pnpm’s catalog: protocol, centralizing Angular version management in pnpm-workspace.yaml.

Changes:

  • Switched Angular dependencies in Angular samples and packages/atomic-angular to catalog:.
  • Added Angular packages to the pnpm workspace catalog: section.
  • Updated pnpm-lock.yaml to reflect catalog-based specifiers.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
samples/headless/rga-angular/package.json Migrates Angular deps/devDeps to catalog:.
samples/headless/rga-angular/.gitignore Removes leading whitespace on .angular entry.
samples/atomic/search-commerce-angular/package.json Migrates Angular runtime deps to catalog: (tooling devDeps remain pinned).
pnpm-workspace.yaml Adds Angular packages/versions to the workspace catalog:.
pnpm-lock.yaml Records Angular packages under catalogs.default and updates specifiers to catalog:.
packages/atomic-angular/package.json Migrates Angular tooling devDependencies to catalog:.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread pnpm-workspace.yaml Outdated
Comment thread samples/atomic/search-commerce-angular/package.json
@louis-bompart
Copy link
Copy Markdown
Collaborator Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

@louis-bompart I've opened a new pull request, #7256, to work on those changes. Once the pull request is ready, I'll request review from you.

… to catalog (#7256)

Co-authored-by: Louis Bompart <lbompart@coveo.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com>
@louis-bompart louis-bompart added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 88a34fb Mar 19, 2026
76 checks passed
@louis-bompart louis-bompart deleted the chore/update-angular-21 branch March 19, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants