Skip to content

chore(atomic): migrate atomic-ipx-modal to Lit and make it public#6967

Merged
alexprudhomme merged 24 commits intomainfrom
copilot/migrate-atomic-ipx-modal-to-lit
Feb 5, 2026
Merged

chore(atomic): migrate atomic-ipx-modal to Lit and make it public#6967
alexprudhomme merged 24 commits intomainfrom
copilot/migrate-atomic-ipx-modal-to-lit

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 14, 2026 •
edited by alexprudhomme
Loading

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-5351

Copilot AI and others added 2 commits January 14, 2026 19:33
@alexprudhomme
Migrate atomic-ipx-modal component to Lit
74cceb9 
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
@alexprudhomme
Add unit tests for atomic-ipx-modal
6aaa01b 
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Copilot AI changed the title [WIP] Migrate atomic-ipx-modal to Lit feat(atomic): migrate atomic-ipx-modal to Lit Jan 14, 2026
Copilot AI requested a review from alexprudhomme January 14, 2026 19:39
@alexprudhomme
Copy link
Copy Markdown
Contributor

alexprudhomme commented Jan 14, 2026

Make it not internal, add stories, mdx and e2e tests @copilot

@alexprudhomme
feat(atomic): make atomic-ipx-modal public and add documentation
70d1ed7 
- Remove @internal tag from component
- Add Storybook stories with Default, WithoutFooter, and Closed variants
- Add MDX documentation with usage examples
- Add E2E tests covering modal display, interactions, and states
- Add page object and fixture for E2E testing

Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 14, 2026

Make it not internal, add stories, mdx and e2e tests @copilot

Done in commit 70d1ed7. The component is now public (removed @internal tag) and includes:

  • Storybook stories: 3 variants (Default, WithoutFooter, Closed) demonstrating different modal configurations
  • MDX documentation: Comprehensive guide with usage examples, slot documentation, behavior explanation, and styling options
  • E2E tests: 11 test cases covering modal display, interactions, content rendering, and state management with page object pattern

All files are linted and ready for review.

Copilot AI changed the title feat(atomic): migrate atomic-ipx-modal to Lit feat(atomic): migrate atomic-ipx-modal to Lit and make it public Jan 14, 2026
@alexprudhomme alexprudhomme added new-lit-component chromatic Opt-out of Chromatic testing labels Jan 15, 2026
@alexprudhomme alexprudhomme force-pushed the copilot/migrate-atomic-ipx-modal-to-lit branch from 719c327 to 1a7b56a Compare January 15, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mikegron mikegron mikegron approved these changes

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme

@lavoiesl lavoiesl Awaiting requested review from lavoiesl lavoiesl was automatically assigned from coveo/dxui

@dguerinCoveo dguerinCoveo Awaiting requested review from dguerinCoveo

@SimonMilord SimonMilord Awaiting requested review from SimonMilord

@louis-bompart louis-bompart Awaiting requested review from louis-bompart

@jpmarceau jpmarceau Awaiting requested review from jpmarceau jpmarceau was automatically assigned from coveo/dev-writers

@npushkarskii npushkarskii Awaiting requested review from npushkarskii npushkarskii was automatically assigned from coveo/dev-writers

@jsmith2-coveo jsmith2-coveo Awaiting requested review from jsmith2-coveo jsmith2-coveo was automatically assigned from coveo/dev-writers

@tbaxter-coveo tbaxter-coveo Awaiting requested review from tbaxter-coveo tbaxter-coveo was automatically assigned from coveo/dev-writers

Assignees

@alexprudhomme alexprudhomme

Copilot code review Copilot

Labels

area:atomic area:documentation area:e2e-tests area:ipx chromatic Opt-out of Chromatic testing new-lit-component team:dev-writers team:dxui team:knowledge-ui-kit-reviewers team:search-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexprudhomme @erocheleau @mikegron @louis-bompart @SimonMilord