Skip to content

chore(atomic): migrate atomic-insight-refine-modal to Lit#6966

Merged
alexprudhomme merged 21 commits intomainfrom
copilot/migrate-atomic-insight-refine-modal
Feb 5, 2026
Merged

chore(atomic): migrate atomic-insight-refine-modal to Lit#6966
alexprudhomme merged 21 commits intomainfrom
copilot/migrate-atomic-insight-refine-modal

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 14, 2026

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-4850

Copilot AI and others added 3 commits January 14, 2026 19:29
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
…ne-modal

Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Copilot AI changed the title [WIP] Migrate atomic-insight-refine-modal component to Lit feat(atomic): migrate atomic-insight-refine-modal to Lit Jan 14, 2026
Copilot AI requested a review from alexprudhomme January 14, 2026 19:38
@alexprudhomme
Copy link
Copy Markdown
Contributor

@copilot Make it not internal and add mdx, stories and e2e tests

… tests

Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 14, 2026

@copilot Make it not internal and add mdx, stories and e2e tests

Done! Removed @internal tag and added:

  • MDX documentation with usage examples and related components
  • Storybook stories with insight facets that auto-open the modal
  • E2E tests with page object, fixture, and test cases for modal visibility, title, close button, filters section, and view results button
  • Comprehensive JSDoc documenting all shadow parts

Commit: 2b90698

@alexprudhomme alexprudhomme changed the title feat(atomic): migrate atomic-insight-refine-modal to Lit chore(atomic): migrate atomic-insight-refine-modal to Lit Jan 15, 2026
Copy link
Copy Markdown
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highlighted a potential slight memory leak, but I don't think it's super big since it's just 1 modal at once.

You can decide what to do with it, I'm sure we had this issue before also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants