chore(atomic): migrate atomic-insight-refine-modal to Lit#6966
Merged
alexprudhomme merged 21 commits intomainfrom Feb 5, 2026
Merged
chore(atomic): migrate atomic-insight-refine-modal to Lit#6966alexprudhomme merged 21 commits intomainfrom
alexprudhomme merged 21 commits intomainfrom
Conversation
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
…ne-modal Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate atomic-insight-refine-modal component to Lit
feat(atomic): migrate atomic-insight-refine-modal to Lit
Jan 14, 2026
Contributor
|
@copilot Make it not internal and add mdx, stories and e2e tests |
… tests Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Contributor
Author
Done! Removed
Commit: 2b90698 |
erocheleau
approved these changes
Feb 3, 2026
Collaborator
erocheleau
left a comment
There was a problem hiding this comment.
I highlighted a potential slight memory leak, but I don't think it's super big since it's just 1 modal at once.
You can decide what to do with it, I'm sure we had this issue before also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
.mdxfileindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-4850