Open
Conversation
added 5 commits
March 10, 2026 22:22
…Redirect were being dropped in the credentials(Authentication) and credentials(Credentials) round-trip methods at lines
Member
alexarchambault
left a comment
There was a problem hiding this comment.
Thanks for opening this, this looks great! I'll review that in more detail in the days to come, then merge I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add credentials support to Cache and fix auto-loading from config files
Expose credentials on the Java Cache API, matching the underlying Scala
FileCache model. Credentials stored in ~/.config/coursier/credentials.properties
(or COURSIER_CREDENTIALS) are now automatically picked up by all entry
points (Fetch, Complete, Versions, ArchiveCache, JvmManager). Also add the ability to manually add FileCredentials
Changes:
and passOnRedirect fields to match coursier's DirectCredentials
FileCache's default config-file credentials are preserved rather than
overridden with an empty list
httpsOnly, and passOnRedirect through Authentication conversion
points, and the Credentials API surface