【修复bug】:修复用户在两次请求之间改了 Key 配置,导致同线程获取相同的不可重入锁导致的死锁。#91
Open
hhzscreate wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
修复bug:
修复用户在两次请求之间改了 Key 配置,导致同线程获取相同的不可重入锁导致的死锁。
线程在
with self._lock里已经持有锁;走到except分支后调用self.next_key(),而next_key()会对同一把非重入锁再次acquire()。第二次 acquire 永久阻塞,锁也就永远不会释放——线程卡死,还占着锁把后来者一起拖死。变更类型
测试
描述你如何测试这些变更: