RCBC-524: OpenTelemetry integration #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the gemspec replacement pattern from `/gemspec/` to `/gemspec$/` to ensure it only matches "gemspec" at the end of lines. This prevents potential partial matches that could cause incorrect Gemfile modifications during the test gem installation process. The $ anchor makes the regex more precise and robust for the automated gem unpacking and bundling workflow.
The bucket_name parameter was missing from the fmt::format call in cb_Backend_query_index_build_deferred, causing the error message to not include the bucket name when reporting deferred index build failures. Which in turn caused build failure with recent GCC, where fmtlib tries to validate format strings compile-time.
avsej
reviewed
Jan 22, 2026
| COUCHBASE_GEM_PATH=$(realpath couchbase-*.gem) | ||
| UNPACKED_GEM_PATH=$(gem unpack ${COUCHBASE_GEM_PATH} | grep "Unpacked gem" | cut -d "'" -f 2) | ||
| gem unpack --spec --target ${UNPACKED_GEM_PATH} ${COUCHBASE_GEM_PATH} | ||
| ruby -i.bak -pe "gsub(/gemspec/, 'gem \"couchbase\", path: \"${UNPACKED_GEM_PATH}\"')" Gemfile |
Member
There was a problem hiding this comment.
@DemetrisChr somehow we need to figure out proper fix here. The idea is to use specific precompiled gem for the tests and avoid fetching it from the repository.
Maybe some other solution will fit better here. Like
gem install ${COUCHBASE_GEM_PATH}
and then, point bundler to use it from there.
or from the different angle, create local gem repository like
mkdir -p my-local-repo/gems
cp ${COUCHBASE_GEM_PATH} my-local-repo/gems/
gem generate_index --verbose --directory my-local-repo/
And then patch Gemfile to use something like
gem "couchbase", path: "my-local-repo/"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the observability work, we should add Meter and Tracer implementations that allow easy integration with OpenTelemetry.
Changes
OpenTelemetryRequestTracerandOpenTelemetryMeter. Both will be shipped as part of thecouchbase-opentelemetrygemstatuson request tracers.TracerErrorandMeterErrorthat wrap any errors coming from the wrapped Otel tracer/meter.