RCBC-527: Include child spans created by the C++ core #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemetrisChr
force-pushed
the
RCBC-527-core-spans
branch
3 times, most recently
from
5378883 to
139d731
Compare
DemetrisChr
force-pushed
the
RCBC-527-core-spans
branch
from
139d731 to
4ac9630
Compare
avsej
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dispatch spans are created by the C++ core. We need to extract the information on those spans and create the spans in Ruby's tracers.
Changes
The infrastructure for getting the core spans into the Ruby-side was already in place (via the
couchbase::core::wrapper_sdk_tracer, and a couple of operations were already using it. This change expands this so all operations extract the core spans. To achieve this, the operations' observability handler should be passed on to all backend operations that support tracing.Results
All tests pass