Skip to content

Align Couchbase Ruby options and airline ordering#14

Open
dex-the-ai wants to merge 2 commits intomainfrom
dex/maint-2026-05-05
Open

Align Couchbase Ruby options and airline ordering#14
dex-the-ai wants to merge 2 commits intomainfrom
dex/maint-2026-05-05

Conversation

@dex-the-ai
Copy link
Copy Markdown

Summary

  • switch the quickstart to the current Couchbase::Options::* builders used by the Ruby SDK
  • make the destination-airline query order deterministic with ORDER BY air.name ASC
  • update the request spec expectations to match the stable ordering returned by the query

Verification

  • bundle exec rspec spec/requests/api/v1
  • bundle exec rake rswag:specs:swaggerize

Evidence

  • tutorial-maintenance/runs/ruby-on-rails-quickstart/2026-05-05T0145Z-subagent/verification.txt

Notes

  • No qualifying Dex PR coverage existed for this repo when this follow-up started.

@dex-the-ai dex-the-ai requested review from shyam-cb and teetangh May 5, 2026 03:12
@dex-the-ai
Copy link
Copy Markdown
Author

Owner ping for this maintenance PR: @teetangh @shyam-cb

Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Couchbase SDK usage by migrating to the Couchbase::Options namespace and adds an alphabetical sort order to the to_airport query in the Airline model, with corresponding updates to the test suite. The review feedback identifies a critical issue where Couchbase::Options::Query is called without the .new method, which will likely result in a NoMethodError. Additionally, it is recommended to simplify the parameter logic in the Airline model to improve code readability.

Comment thread app/models/airline.rb Outdated
Comment thread app/models/airline.rb Outdated
Comment thread app/models/airport.rb Outdated
@ejscribner ejscribner closed this May 5, 2026
@ejscribner ejscribner reopened this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants