test_pipeline should use temporary output directory#454
Merged
GallegoSav merged 4 commits intocositools:developfrom Jan 26, 2026
Merged
test_pipeline should use temporary output directory#454GallegoSav merged 4 commits intocositools:developfrom
GallegoSav merged 4 commits intocositools:developfrom
Conversation
than whatever directory pytest was run from
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
|
Hi @jdbuhler , I see some commits from this pr are coming from your other pull request on the DataIO. I suppose we need to merge first the pr 457 before this one |
Contributor
Author
|
Ugh -- I thought I branched from develop. Oh well. |
GallegoSav
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_pipeline runs two scripts that produce output files (bin.yaml and binned_data_local.hdf5). Right now, these files are left in whichever directory the script was run from, which is to say wherever pytest was run. This patch directs them to a temporary directory created by pytest instead so as not to litter the working tree.