Skip to content

test_pipeline should use temporary output directory#454

Merged
GallegoSav merged 4 commits intocositools:developfrom
McKelvey-Engineering-CSE:fix-pipeline-test
Jan 26, 2026
Merged

test_pipeline should use temporary output directory#454
GallegoSav merged 4 commits intocositools:developfrom
McKelvey-Engineering-CSE:fix-pipeline-test

Conversation

@jdbuhler
Copy link
Copy Markdown
Contributor

test_pipeline runs two scripts that produce output files (bin.yaml and binned_data_local.hdf5). Right now, these files are left in whichever directory the script was run from, which is to say wherever pytest was run. This patch directs them to a temporary directory created by pytest instead so as not to litter the working tree.

than whatever directory pytest was run from
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.36%. Comparing base (72e2fb3) to head (e29c194).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
cosipy/threeml/COSILike.py 66.66% 23 Missing ⚠️
Files with missing lines Coverage Δ
cosipy/threeml/COSILike.py 73.17% <66.66%> (+3.69%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GallegoSav
Copy link
Copy Markdown
Contributor

GallegoSav commented Jan 23, 2026

Hi @jdbuhler , I see some commits from this pr are coming from your other pull request on the DataIO.

I suppose we need to merge first the pr 457 before this one

@jdbuhler
Copy link
Copy Markdown
Contributor Author

Ugh -- I thought I branched from develop. Oh well.

@GallegoSav GallegoSav merged commit f80b37d into cositools:develop Jan 26, 2026
4 checks passed
@jdbuhler jdbuhler deleted the fix-pipeline-test branch January 26, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants