chore(impact): make --file the primary flag, keep --file_path as alias#526
Merged
Conversation
`ecp impact`'s disambiguation flag was `--file_path` (with `--file-path` alias). Both are easy to mistype, and clap's "a similar argument exists" tip pointed at the longer name. The struct field is already `file`, so the snake_case external name was gratuitous. Promote `--file` to the primary spelling; keep `--file_path` and `--file-path` as aliases so existing scripts and habits don't break. clap now suggests `--file` on a typo, and `--help` shows `ecp impact --file <FILE>`. Pure flag rename with back-compat aliases — no behaviour change, no schema/parser surface.
Contributor
ecp impact cache (0 symbols) — internal, used by
|
coseto6125
added a commit
that referenced
this pull request
May 31, 2026
The v0.6.2 section was generated by the release-PR (#524) bump before #523/#525/#526 merged, so it listed only #520/#521/#522. Backfill the three before tagging v0.6.2 so the release notes match what the tag actually ships: - #525 field-reassign collision fix (Bug Fixes) - #523 cypher prop-filter refactor (Refactor) - #526 `--file` flag rename (Chore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ecp impact's disambiguation flag was--file_path(with a--file-pathalias) — both easy to mistype, and clap's "a similar argument exists" tip pointed at the longer name. The struct field is alreadyfile, so the snake_case external name was gratuitous.Promote
--fileto the primary spelling; keep--file_pathand--file-pathas aliases so existing scripts and muscle memory don't break. clap now suggests--fileon a typo, and--helpshowsecp impact --file <FILE>.Verified all three spellings resolve identically against a real repo; a
--filtypo now suggests--file.Pure flag rename with back-compat aliases — no behaviour change, no schema/parser surface.