feat!: RFC 5.0 Phase 4 — remove the v3 mapping engine (one engine story)#48
Merged
Merged
Conversation
BREAKING: the HTML-intermediate pipeline is gone. Every conversion rides parse → universal → convert; there is no fuzzy-mapping fallback. - Delete translation-bridge/core/class-mapping-engine.php (863 lines) and the translator's mapping-fallback branch + map_components(); the content-survival check is now an advisory warning quantified by the per-conversion fidelity stat; stats route is always 'universal' - Drop the mapping-engine requires from functions.php and the matrix test (all 182 pairs pass on the universal route alone — verified before and after removal) - DEVTB_Component is no longer an interchange format on any public surface (the mapping engine was its last pipeline consumer); it remains the PHP engine's internal model - Deprecation copy corrected: the translate alias survives 5.0 and is removed in 5.1 (RFC one-minor policy); devtb/README engine story rewritten as "one schema, two conforming runtimes" - CHANGELOG carries the breaking entry + migration notes Suites: PHP 344/5,691 · Python 306 · 3 e2e smokes × 2 engines — green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC 5.0 Phase 4 (breaking). The HTML-intermediate pipeline is removed:
class-mapping-engine.php(863 lines of v3 similarity-scoring) is deleted along with the translator's mapping-fallback branch. Every conversion — both engines, all surfaces — rides parse → universal → convert. This completes the RFC: one schema, two conforming runtimes.Why it's safe
translate()signatures unchanged.DEVTB_Componentremains the PHP engine's internal model — it just isn't an interchange format anywhere public (the mapping engine was its last pipeline consumer).Also in this PR
translatealias survives 5.0 and is removed in 5.1 (one-minor policy).DEVTB_Mapping_Engineusers →parse_to_universal()/translate_universal()).Test evidence
PHPUnit 344/5,691 · pytest 306 (39/39 matrix) · 3 e2e smokes × 2 engines — all green, plus a live CLI spot-check (route=universal, fidelity reported, 5.1 deprecation copy).
🤖 Generated with Claude Code