Skip to content

Switch to github actions for CI#126

Closed
wader wants to merge 1 commit intocortesi:masterfrom
wader:github-actions
Closed

Switch to github actions for CI#126
wader wants to merge 1 commit intocortesi:masterfrom
wader:github-actions

Conversation

@wader
Copy link
Copy Markdown
Collaborator

@wader wader commented Jun 24, 2025

No description provided.

@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Jun 24, 2025

Probably need some assistance to enable github actions

@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Mar 23, 2026

Not sure what do to about this one? do we need admin right to enable actions or will they just start working if we merge this? the current travis CI is broken so maybe merge this just to remove it?

@chebread
Copy link
Copy Markdown
Contributor

Not sure what do to about this one? do we need admin right to enable actions or will they just start working if we merge this? the current travis CI is broken so maybe merge this just to remove it?

@wader,

I completely agree that we need to get rid of the broken Travis CI. I will take on investigating whether GitHub Actions requires admin rights to be enabled first, or if it works automatically upon merge.

Could you please give me a little bit of time to look into this before we proceed with the merge? Slightly off-topic, but just as a heads-up, I am currently a high school student, so my availability is a bit limited during the weekdays due to classes. I will run some tests on my forked repository and get back to you as soon as possible!

@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Mar 23, 2026

Could you please give me a little bit of time to look into this before we proceed with the merge? Slightly off-topic, but just as a heads-up, I am currently a high school student, so my availability is a bit limited during the weekdays due to classes. I will run some tests on my forked repository and get back to you as soon as possible!

Sure, no stress :) yes would be good to also review the github action, maybe we want to run for specific go versions (last two LTS?) instead of just stable? maybe we want fmt/lint error?

@chebread
Copy link
Copy Markdown
Contributor

Hi @wader,

I've implemented the fixes for the CI issues discussed in this PR, including a full migration to GitHub Actions with Go 1.25.x support.

Since I don't have permission to push directly to your branch, I have opened a new, modernized PR at #134 which passes all tests on Linux, macOS, and Windows.

Please take a look and let me know if we can coordinate to get these improvements merged!

@wader
Copy link
Copy Markdown
Collaborator Author

wader commented Mar 26, 2026

Ok! let's continue in #134

@wader wader closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants