Skip to content

Add AdMob UMP/CMP API code examples & gotchas#168

Closed
XeduR wants to merge 0 commit intocoronalabs:masterfrom
XeduR:master
Closed

Add AdMob UMP/CMP API code examples & gotchas#168
XeduR wants to merge 0 commit intocoronalabs:masterfrom
XeduR:master

Conversation

@XeduR
Copy link
Copy Markdown
Contributor

@XeduR XeduR commented Nov 28, 2023

The current documentation pages are incomplete and lack valuable information on how to properly use the new AdMob UMP/CMP API.

This topic has been discussed in detail over at the forums: https://forums.solar2d.com/t/new-requirements-from-google-to-show-ads-cmp/355707. If there are further improvements that someone things could be made, feel free to add to or modify the pages further.

@XeduR
Copy link
Copy Markdown
Contributor Author

XeduR commented Nov 28, 2023

Colin reminded me on the forums of how appId has not been set via admob.init() in ages, but rather via build.settings, as the main admob documentation page mentions already. I've amended the PR to remove the appId as a parameter in the init function and I've instead added testMode=true to each code example's init call.

@XeduR
Copy link
Copy Markdown
Contributor Author

XeduR commented Dec 4, 2023

@scottrules44 Could you check if these rewritten and extended AdMob UMP/CMP documentation pages are up to par?

One thought that crossed my mind was adding a mention somewhere that the message needs to also be set up over at AdMob's portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant