[Feature] Package the project as a ng library and more#1
Open
tinesoft wants to merge 4 commits intocornflourblue:masterfrom
Open
[Feature] Package the project as a ng library and more#1tinesoft wants to merge 4 commits intocornflourblue:masterfrom
tinesoft wants to merge 4 commits intocornflourblue:masterfrom
Conversation
Author
|
Hi, Any plan on integrating this PR? |
|
@tinesoft You did realy good work, don't you want to publish it to npm by yourself? |
Author
|
@dhilt Thank you 👍 , and sorry for the delay in responding. Yes i'd like to, but i don't want to take away any credits, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @cornflourblue ,
Thanks for this project! I was about to write something very similar, when i came accross your blog. The project has almost everything i needed and is very well written, Good job 👍
One little caveat though, the project is a bit cumbersome to integrate in a real-world ng project (need to copy/paste files around :(, ... )
So i'm submitting this PR, which basically makes a library out-of your code, for easy integration in ng projects, like any other angular libraries.
This was pretty straightforward, using a tool i created for that exact purpose.
So, what you'll get out of the box:
npm install <lib-name>compodocTravis CIgulpHere is what the demo app looks like (notice the brand new logo :) ) :
A bit more info:
ngx-alert-notifications, to make @IgorMinar happy! (#ItsJustAngular)Ngaand components byngato follow naming conventions and best practices (see ng-bootstrap project for example)To play around locally with the PR:
yarnornpm installfrom root foldergulp buildto build the libraryyarnornpm installfromdemo/foldergulp serve:demo(from root folder) to see the demo app (http:localhost:4200)If you merge the PR, here are a couple of things you must adjust:
ngx-alert-notifications.git/configfile in the project folder, to point to the new URL :https://github.com/cornflourblue/ngx-alert-notifications.git.yo-rc.json,package.jsonfiles (this is not mandatory)To publish:
gulp release version=majorThat it!
I plan to submit more PRs to improve the library in the future.
If you have a question, drop me a line!
Cheers!