fix: Livewire interpolation is weird#2541
Conversation
jbocce
left a comment
There was a problem hiding this comment.
@wayfarer3130 the code changes look fine. However, I tried testing it locally both with the contour interpolation example (i.e. bun run example interpolationcontoursegmentation) and locally linking OHIF to your branch. I still see the weird behaviour.
If and when you decide to make further changes, please consider adding @aimee-ferreira and at the very least she can test the live example.
ScreenHunter.Jan.07.13.29.mp4
|
@jbocce - my test cases were a little too consistent - when I vary the number of control points more it seems that it doesn't always interpolate between the control points correctly to lave a straight line across the end. The current change improves things, but I will need to think if there is a solution generally or not. |
jbocce
left a comment
There was a problem hiding this comment.
The code changes look fine. I did a bit of testing and it seems good too. Great job. Please consider adding @aimee-ferreira for more thorough testing.
|
@aimee-ferreira - I just merged this PR into CS3D. The test class to use is interpolationcontoursegmentation. |
Context
Fixes [#5641]
Livewire interpolation currently interpolates the contour closure, which is a straight line originally. That causes display issues.
Changes & Results
Don't interpolate closure
Testing
Open segmentation mode on a volume
Active livewire with interpolation on (see 5641)
Draw contours around the outside of a body or other hard defined object separated by several slices
View the intermediate slices - the contour closure should be a straight line if the original contour was closed by a straight line and livewire if it was clsoed by clicking on the starting point.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment