fix(chore): Reduce combobox and date-picker re-render#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces DOM churn in combobox and date-picker re-renders. Both components subscribe to Zag machine updates and call
render()on every state change; previously they tore down and rebuilt large parts of the list/calendar on each pass.Changes
assets/components/combobox.tsremove()all items/groups, re-clone from templates) with incremental sync:data-value, clone only missing ones, reorder withinsertBefore, drop filtered-out itemsquerySelectorAll)assets/components/date-picker.ts<tr>/<td>nodes instead oftbody.innerHTML = ""data-date-cell(day:YYYY-M-D, month:{year}-{month}, year:{year})Tests
assets/test/component/combobox.test.ts: flat reuse, filter removal, grouped reuseassets/test/component/date-picker.test.ts: day cell and header reuse on repeated renderWhy
On every LiveView patch or Zag state update (filter, open, select, navigate month), the old code destroyed and recreated every list item or calendar cell. That added layout cost, broke focus/hover stability, and scaled poorly with large option lists or open calendars.