This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Open
Conversation
I was spending some time investigating how `update_engine` works, and when first starting out it took me a little bit to figure out that there were separate `update_engine_client` vs `update_engine`. Having them both in `/usr/sbin` is annoying for bash completion. This is just a minor "papercut"; I'm mostly using this to test running through the development/contribution process. I am assuming nothing tries to find these binaries directly and only uses the systemd service and/or DBus API; I didn't see any obvious hits in `repo grep update_engine`. Signed-off-by: Colin Walters <walters@verbum.org>
Contributor
|
LGTM, but I worry if this will break anyone who has systemd dropins for update-engine. If they have a dropin overwriting the ExecStart to add additional flags, this will break them. I'm not sure if there's actually users doing that, but it's something to consider. |
Member
Author
|
Do you (or anyone) have a sense of whether there are flags that people might want to tweak? |
Contributor
|
While I think that this papercut is technically ok, I think that at this point in CL lifetime it is not worth pursuing this with the risk of breaking existing customized setups. I'd be inclined to just close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was spending some time investigating how
update_engineworks, and when firststarting out it took me a little bit to figure out that there were separate
update_engine_clientvsupdate_engine. Having them both in/usr/sbinisannoying for bash completion.
This is just a minor "papercut"; I'm mostly using this to test running
through the development/contribution process.
I am assuming nothing tries to find these binaries directly and only uses the
systemd service and/or DBus API; I didn't see any obvious hits in
repo grep update_engine.Signed-off-by: Colin Walters walters@verbum.org