This repository was archived by the owner on Sep 22, 2020. It is now read-only.
prometheus: move promDistBlockPeerFailures to readFromPeer()#425
Open
nak3 wants to merge 1 commit intocoreos:masterfrom
nak3:prometheus-getblock
Open
prometheus: move promDistBlockPeerFailures to readFromPeer()#425nak3 wants to merge 1 commit intocoreos:masterfrom nak3:prometheus-getblock
nak3 wants to merge 1 commit intocoreos:masterfrom
nak3:prometheus-getblock
Conversation
Contributor
|
Can you explain briefly why you want to make this change? Also we actually might increase the counter in getblock func. Moving the accounting to the caller might double count if you do not change getblock. |
nak3
changed the title
Contributor
Author
|
Sure, I explained it in the first comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prometheus: move promDistBlockPeerFailures to readFromPeer()
ReadLevel doesn't increment the promDistBlockPeerFailures when we set
ReadSpread in current code. Since GetBlock() for remote peers are
called in readFromPeer, this patch moves promDistBlockPeerFailures
incrementation to readFromPeer()