Merged
Conversation
coreosbot-releng
force-pushed
the
repo-templates
branch
from
c49b55a to
33d2fc1
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
2 times, most recently
from
9f1ede3 to
b0029d7
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
4 times, most recently
from
0e6d94e to
0848663
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
0848663 to
e0619a9
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
e0619a9 to
a20c381
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
a20c381 to
de67d50
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
de67d50 to
048d0b6
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
048d0b6 to
a19cc7d
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
a19cc7d to
37d3a0e
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
4 times, most recently
from
1dd02de to
307c9c4
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
307c9c4 to
70e4036
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
2 times, most recently
from
db53a3c to
2bd832a
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
2bd832a to
9f4e1e1
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
9f4e1e1 to
9f26732
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
9f26732 to
a5e2f3f
Compare
Member
|
There are a few lints failing in https://github.com/coreos/ign-converter/actions/runs/23151216792/job/67253304938?pr=54. Can you try fixing those? @fangge1212 |
Contributor
Yes, I will do it |
fangge1212
added a commit
to fangge1212/coreos-ign-converter
that referenced
this pull request
Mar 26, 2026
Address linting errors that prevent PR coreos#54 (repo templates sync) from merging. These issues were previously undetected by golangci-lint v1.52.2 but are caught by the newer v2.11.3. Changes: - internal/main.go: Remove redundant type declarations and check errors in defer statements (errcheck, staticcheck ST1023) - util/util.go: Rename UsesNetworkdError to ErrUsesNetworkd following Go error naming conventions (staticcheck ST1012) - translate/*: Lowercase error message strings (staticcheck ST1005) - translate/*: Remove redundant embedded field selectors (staticcheck QF1008) All existing tests pass. No functional changes. Fixes golangci-lint issues found in: https://github.com/coreos/ign-converter/pull/54/checks Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Fangge Jin <fjin@redhat.com>
Contributor
|
Address linting errors that prevent PR coreos#54 (repo templates sync) from merging. These issues were previously undetected by golangci-lint v1.52.2 but are caught by the newer v2.11.3. Changes: - internal/main.go: Remove redundant type declarations and check errors in defer statements (errcheck, staticcheck ST1023) - util/util.go: Rename UsesNetworkdError to ErrUsesNetworkd following Go error naming conventions (staticcheck ST1012) - translate/*: Lowercase error message strings (staticcheck ST1005) - translate/*: Remove redundant embedded field selectors (staticcheck QF1008) All existing tests pass. No functional changes. Fixes golangci-lint issues found in: https://github.com/coreos/ign-converter/pull/54/checks Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Fangge Jin <fjin@redhat.com>
Ignore lint for this one to limit potential downstream changes.
travier
force-pushed
the
repo-templates
branch
3 times, most recently
from
561dc7a to
91f5a7f
Compare
Fixes: ST1005: error strings should not be capitalized (staticcheck) Fixes: QF1008: could remove embedded field "Node" from selector (staticcheck) Fixes: QF1008: could remove embedded field "FileEmbedded1" from selector (staticcheck)
travier
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by GitHub workflow (source).
Sync with coreos/repo-templates@31f11ac.