Skip to content

Conversation

@ningmingxiao
Copy link

@ningmingxiao ningmingxiao commented Dec 23, 2025

assembler docker image is too big
before this commit 5.17GB after this commit 4.73GB

@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2025

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to reduce the number of layers in the Docker image by consolidating RUN commands, which is a great goal for optimizing image size and build speed.

The consolidation of the first set of RUN commands is done well. However, the second, larger RUN block introduces a critical issue where shell comments break the command chain, preventing most of the commands from executing. It also includes an unsafe directory removal operation.

My review includes a critical comment with a suggested fix that resolves these issues while preserving the single-layer approach and improving code style.

Consolidate RUN commands for efficiency and cleanup.

Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant