package.json editor#60
Open
arieljake wants to merge 9 commits intocoreh-deprecated:masterfrom
arieljake:master
Open
package.json editor#60arieljake wants to merge 9 commits intocoreh-deprecated:masterfrom arieljake:master
arieljake wants to merge 9 commits intocoreh-deprecated:masterfrom
arieljake:master
Conversation
Member
|
Hey @arieljake, is there a reason why this was closed? do you want me to wait for something before merging it? |
Member
|
BTW, thanks for the patch :-D |
Author
|
no reason other than that I wanted to stop new commits from being added. This is my first pull request so im trying to figure out how to limit the commits i put into it. |
… added show-line-numbers and indent-unit preferences dialog auto saves :input fields as cookies by the field 'name' preferences dialog, on saving line numbers pref, updates code editors: ui -> editor pool -> editors preferences dialog shows/hides but does not rebuild each time anymore NOTE: all editor types return "this" from constructor not just DIV element anymore, and to preserve backwards-compatibility, sets the root DIV as 'this.element'
Author
|
to help with handling pull requests, should we prioritize creating some tests? |
Author
|
also, if you do accept the additions, can you review my CSS styling and adjust as necessary to keep Nide beautiful! :) |
also, debug engines cheat
gear menu and code runner using new base classes beginning of code autocompletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I would like to offer a contribution to Nide: an editor for package.json files.
It was built in the nature of the other editors in the app.
I do have a lingering question about sync'ing files between editors.