Skip to content

Quote service IPs to prevent YAML misinterpretation#260

Open
PseudoResonance wants to merge 1 commit into
coredns:masterfrom
PseudoResonance:master
Open

Quote service IPs to prevent YAML misinterpretation#260
PseudoResonance wants to merge 1 commit into
coredns:masterfrom
PseudoResonance:master

Conversation

@PseudoResonance
Copy link
Copy Markdown

Why is this pull request needed and what does it do?

IPv6 in YAML needs to be quoted because certain IPs can cause misinterpretations.

One example is an IP ending in a colon, ex: fd:: as YAML thinks it's a new key.

Additionally, I replaced toYaml with toJson on the IP lists. I don't think lists are as problematic, but I figured there might be some edge-case and it's safer to just ensure they're properly quoted. It could be replaced with a range loop and print each IP manually with quotes, but toJson is simpler and still compliant.

Which issues (if any) are related?

None

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Signed-off-by: PseudoResonance <75700a85-1205-4740-aebf-4413a352e81b@otake.pw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant