notifications: add enable sort and asc/desc order#95
Open
asyba wants to merge 2 commits intocoredevices:masterfrom
Open
notifications: add enable sort and asc/desc order#95asyba wants to merge 2 commits intocoredevices:masterfrom
asyba wants to merge 2 commits intocoredevices:masterfrom
Conversation
Contributor
Author
|
cc @sjp4 |
Member
|
Couple of high-level comments (and sorry it took so long):
|
e775551 to
636bab7
Compare
Contributor
Author
|
Member
|
Thanks for the screenshots. I think there's a good chance that row of filters will be too long on some devices (or where the user has a large font size) - perhaps we should make it horizontally scrollable (like e.g. how we have the filter bar scrollable on LockerScreen) |
636bab7 to
84fa3fc
Compare
84fa3fc to
9eaf65a
Compare
Contributor
Author
|
@sjp4 yes true, added that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Tested iOS only
