Skip to content

Comments

notifications: add enable sort and asc/desc order#95

Open
asyba wants to merge 2 commits intocoredevices:masterfrom
asyba:notifications_sort_update
Open

notifications: add enable sort and asc/desc order#95
asyba wants to merge 2 commits intocoredevices:masterfrom
asyba:notifications_sort_update

Conversation

@asyba
Copy link
Contributor

@asyba asyba commented Jan 8, 2026

  • Added a new sorter called "Enabled" to order notification list by Toggle enable.
  • Added Ascending and Descending order, for example if you click order by Name it will order like a,b,c etc but if you click again order will be by z,y,x etc , the same for Recent, Enabled. (not sure for "Count" since that is not supported by iOS)

Tested iOS only

@asyba asyba changed the title notifications add enable sort and asc/desc order notifications: add enable sort and asc/desc order Jan 8, 2026
@asyba
Copy link
Contributor Author

asyba commented Jan 8, 2026

cc @sjp4

@sjp4
Copy link
Member

sjp4 commented Feb 13, 2026

Couple of high-level comments (and sorry it took so long):

  • Would be be better for this to be a filter, rather than a sort?
  • If we enable sorting in different directions, I think that needs to be reflected in the UI - e.g. by reversing the Icons.AutoMirrored.Filled.Sort icon (and maybe also using that instead of the checkmark against the individual items in the dropdown?)

@asyba asyba force-pushed the notifications_sort_update branch from e775551 to 636bab7 Compare February 15, 2026 13:56
@asyba
Copy link
Contributor Author

asyba commented Feb 15, 2026

Couple of high-level comments (and sorry it took so long):

  • Would be be better for this to be a filter, rather than a sort?
  • If we enable sorting in different directions, I think that needs to be reflected in the UI - e.g. by reversing the Icons.AutoMirrored.Filled.Sort icon (and maybe also using that instead of the checkmark against the individual items in the dropdown?)

yes, done.
like this


@sjp4
Copy link
Member

sjp4 commented Feb 15, 2026

Thanks for the screenshots. I think there's a good chance that row of filters will be too long on some devices (or where the user has a large font size) - perhaps we should make it horizontally scrollable (like e.g. how we have the filter bar scrollable on LockerScreen)

@asyba asyba force-pushed the notifications_sort_update branch from 636bab7 to 84fa3fc Compare February 16, 2026 03:36
@asyba asyba force-pushed the notifications_sort_update branch from 84fa3fc to 9eaf65a Compare February 16, 2026 03:41
@asyba
Copy link
Contributor Author

asyba commented Feb 16, 2026

@sjp4 yes true, added that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants