treewide: revert ruff lint for sdk files#866
Open
jplexer wants to merge 1 commit intocoredevices:mainfrom
Open
treewide: revert ruff lint for sdk files#866jplexer wants to merge 1 commit intocoredevices:mainfrom
jplexer wants to merge 1 commit intocoredevices:mainfrom
Conversation
some things that ruff sees as "unused" are actually quite important for the SDK Signed-off-by: Joshua Jun <joshuajun@proton.me>
gmarull
requested changes
Feb 20, 2026
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
Some of the fixes are valid; I guess some of these scripts are used by apps using import *? Add a # noqa: FXXX to unused imports we want to preserve for 3rd party
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some things that ruff sees as "unused" are actually quite important for the SDK