Open
Conversation
Member
Author
|
I love finding errors that only appear once you do clean builds |
Member
Author
|
Waiting on pebble-dev/pebbleos-docker#3 |
gmarull
reviewed
Feb 19, 2026
Member
Author
|
Waiting on Moddable-OpenSource/moddable#1566 |
gmarull
reviewed
Feb 19, 2026
Member
Author
|
@gmarull compliance check is failing because I pulled in some code that is licensed ISC, which is compatible in our code base, but the compliance check obviously only checks for Apache 2. Also, code will not build yet because it's missing that one commit from Moddable, but I uploaded it anyway for review :) |
Member
|
sorry for the rebase headache :-)... |
Signed-off-by: Joshua Jun <joshuajun@proton.me>
Signed-off-by: Joshua Jun <joshuajun@proton.me>
jplexer
force-pushed
the
moddable
branch
2 times, most recently
from
853da5b to
ac71f47
Compare
Signed-off-by: Joshua Jun <joshuajun@proton.me>
Signed-off-by: Joshua Jun <joshuajun@proton.me>
The Moddable XS JavaScript engine requires standard C library declarations beyond what pblibc previously provided. Extend the libc stub headers with missing declarations (fpclassify, isfinite, isnormal, fprintf, vprintf, stderr, longjmp noreturn attribute) and chain float.h to the toolchain header via include_next for FLT_EVAL_METHOD. Add math implementations from NuttX for fabsl, floor, log, and log2. Signed-off-by: Joshua Jun <joshuajun@proton.me>
Send DEINIT event to process before setting exit trap to ensure blocked syscalls (like sys_get_pebble_event) can return and trigger proper cleanup flow. Signed-off-by: Joshua Jun <joshuajun@proton.me>
Add support for 'moddable' project type in build configuration. Auto-inject MOD resource from compiled XS archive for moddable builds. Update resource generation to handle moddable projects alongside app and rocky types. Signed-off-by: Joshua Jun <joshuajun@proton.me> # Conflicts: # sdk/waftools/pebble_sdk.py # sdk/waftools/process_sdk_resources.py Signed-off-by: Joshua Jun <joshuajun@proton.me>
Instead of requiring --js-engine to be passed explicitly, default to moddable for boards with HAS_MODDABLE_XS and none otherwise. This keeps the CLI override available but removes the need for CI workflows to specify --js-engine per board. Also force JS_ENGINE to none for PRF builds and move the PRF env switch earlier in build() so moddable is not compiled into recovery firmware. Signed-off-by: Joshua Jun <joshuajun@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.