fw/applib/ui/vibes: add per-segment amplitude control to public SDK#833
Open
mdrunk wants to merge 1 commit intocoredevices:mainfrom
Open
fw/applib/ui/vibes: add per-segment amplitude control to public SDK#833mdrunk wants to merge 1 commit intocoredevices:mainfrom
mdrunk wants to merge 1 commit intocoredevices:mainfrom
Conversation
1 task
Member
rebase |
Author
so is this something that I need to do? I'm pretty good with code, but absolute trash with github, which is why claude is involved with this PR at all. |
Member
|
just git rebase against upstream main, then force-push |
mdrunk
force-pushed
the
feature/vibe-amplitude-control
branch
2 times, most recently
from
d34f702 to
2f53622
Compare
Member
|
please adjust commit title to e..g. |
mdrunk
changed the title
kljohann
reviewed
Feb 19, 2026
mdrunk
force-pushed
the
feature/vibe-amplitude-control
branch
from
2f53622 to
d5c14a7
Compare
Expose vibration motor intensity control to apps via a new vibes_enqueue_custom_pattern_with_amplitudes() API. The internal syscall (sys_vibe_pattern_enqueue_step_raw) and hardware drivers already support per-step strength values; this bridges the gap in the public SDK. Also fix a pre-existing issue where active vibration patterns were not explicitly stopped on app exit by adding sys_vibe_pattern_clear() to the app cleanup path. Signed-off-by: Jeremy Lambert <jeremylambert@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mdrunk
force-pushed
the
feature/vibe-amplitude-control
branch
from
d5c14a7 to
7cd4f6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose vibration motor intensity control to apps via a new vibes_enqueue_custom_pattern_with_amplitudes() API. The internal syscall (sys_vibe_pattern_enqueue_step_raw) and hardware drivers already support per-step strength values; this bridges the gap in the public SDK.
Also fix a pre-existing issue where active vibration patterns were not explicitly stopped on app exit by adding
sys_vibe_pattern_clear() to the app cleanup path.