fw/drivers/accel: remove axis/direction from shake event

[gmarull]

It's just useless. You just want to know if watch shake occurred, in any direction.

[jplexer]

I don't think we should do this. The AccelTapHandler callback signature includes axis and direction as parameters, and this is part of the public SDK API that app developers rely on. The developer documentation explicitly describes how axis tells you which axis the tap was detected along, and direction indicates positive (1) or negative (-1).
There are apps out there that use this information, for example, to distinguish between different tap orientations and trigger different behaviors depending on which way the watch was flicked. Removing this would break those apps or silently degrade their functionality.
Even if most use cases only care about "a shake happened," that doesn't mean the axis/direction info is useless for everyone.

[gmarull]

I don't think we should do this. The AccelTapHandler callback signature includes axis and direction as parameters, and this is part of the public SDK API that app developers rely on. The developer documentation explicitly describes how axis tells you which axis the tap was detected along, and direction indicates positive (1) or negative (-1). There are apps out there that use this information, for example, to distinguish between different tap orientations and trigger different behaviors depending on which way the watch was flicked. Removing this would break those apps or silently degrade their functionality. Even if most use cases only care about "a shake happened," that doesn't mean the axis/direction info is useless for everyone.

Something in PebbleOS is actually broken, see:

void accel_tap_service_subscribe(AccelTapHandler handler) {
  AccelServiceState * session = accel_service_private_get_session(PebbleTask_Unknown);
  accel_session_shake_subscribe(session, handler);
}

So, tap means, in practice, subscribe to shake events. That's wrong. Our sensor can detect "motion", tap and double tap. We need to fix this...

[gmarull]

@jplexer see latest push for split

[jplexer]

yeah thats better! We just gotta figure out how we do legacy apps that expect the axis at that callback

[gmarull]

yeah thats better! We just gotta figure out how we do legacy apps that expect the axis at that callback

The shake API is actually a new one; tap is kept the same, but we now need to feed the event from the sensor.

[jplexer]

oh haha I misread that!