Skip to content

Conversation

@dHIM24
Copy link
Contributor

@dHIM24 dHIM24 commented Feb 2, 2026

BottomSheet
  • Исправлен визуальный скачок шторки при динамической смене magneticAreasProp (например, skeleton → content).
  • При изменении пропа временно отключается CSS transition для мгновенного перехода на новую позицию.

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало

Было:

2026-02-03.00.52.06.mov

Стало:

2026-02-03.00.51.32.mov

Код для песочницы:

function Example() {
    const [loading, setLoading] = React.useState(true);

    React.useEffect(() => {
        setTimeout(() => {
            setLoading(false);
        }, 2000);
    }, []);

    return (
        <BottomSheet
            open={true}
            onClose={() => null}
            magneticAreas={loading ? undefined : [10, 20, 50, '100%']}
            initialActiveAreaIndex={2}
        >
            {loading ? <div>Loading...</div> : <div>Content</div>}
        </BottomSheet>
    );
}
render(<Example />);

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

🦋 Changeset detected

Latest commit: bbcaaae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Feb 3, 2026

Pull Request Test Coverage Report for Build 21623617968

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 79.856%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bottom-sheet/src/component.tsx 6 9 66.67%
Totals Coverage Status
Change from base Build 21518168199: -0.007%
Covered Lines: 9729
Relevant Lines: 11419

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Demo build

https://core-ds.github.io/core-components/2036

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Snapshot Release

Successfully released the following packages:

  1. @alfalab/core-components-bottom-sheet@7.4.3-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  2. @alfalab/core-components-custom-picker-button@3.1.1-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  3. @alfalab/core-components-gallery@6.0.13-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  4. @alfalab/core-components-input-autocomplete@13.1.1-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  5. @alfalab/core-components-international-phone-input@3.2.9-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  6. @alfalab/core-components-intl-phone-input@10.0.12-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  7. @alfalab/core-components-picker-button@12.1.1-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  8. @alfalab/core-components@49.14.1-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  9. @alfalab/core-components-select@18.2.9-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  10. @alfalab/core-components-select-with-tags@9.0.12-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  11. @alfalab/core-components-table@3.0.12-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  12. @alfalab/core-components-tabs@9.2.9-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

  13. @alfalab/core-components-tooltip@8.0.12-bbcaaaee0ecdeb2614add40a4f9eedb965f68f28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants