-
Notifications
You must be signed in to change notification settings - Fork 63
feat(segmented-control): добавить view skeleton [DS-14045] #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3f2be4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 21607372055Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| * Показывает скелетон вместо контента | ||
| * @default false | ||
| */ | ||
| showSkeleton?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Обсудим потом вариант объеденения пропса?
Например
skeleton: {show: boolean, props: {}}
|
|
||
| const skeletonBorderRadius = (() => { | ||
| if (shape === 'rounded') { | ||
| return sizeClassName === 'size-40' ? 20 : 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тут и в остальных местах идет проверка на size-40. в принципе можно сразу вывести функцию:
size === 40 || size === 'xs'.
skeletonдля компонентаSegmentedControl.Чек лист
Если есть визуальные изменения
Код для песочницы: