-
Notifications
You must be signed in to change notification settings - Fork 63
feat/remove css font vars #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c097762 The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 21289965380Details
💛 - Coveralls |
Demo build (default) |
Demo build (alfasans) |
Snapshot release (default)Successfully released the following packages:
|
Snapshot release (alfasans)Successfully released the following packages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У нотификейшна должен быть жирный заголовок (акцент)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
если включен болд, то он должен влиять и на плейсхолдер и на вэлью
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Для вэлью и лейбла тут используется стариновский
20–24 (Typography.Title view='xsmall' weight='regular')
Ты меняешь его на системный 18-22 (Typography.Title view='xsmall' weight='regular')
Выглядит сильно неравнозначно, разные и лайнхейты и размер. Я бы вручную подхачил тут, и заменил на 20-24 regular. Такого стиля у нас нет, это хардкод.
Для сколлапсированного лейбла можно использовать 12–16 (Typography.Text view='secondary-medium'), такой стиль есть. Для него замена сейчас тоже выглядит неравнозначной
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
похоже промахнулись лайнхейтом, стал 24 а был 20 вроде
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а что тут происходит?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и тут
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и тут)
| --primary-tablist-mobile-font-family: var(--font-family-system); | ||
| --primary-tablist-mobile-padding: var(--gap-0) var(--gap-0) var(--gap-12); | ||
|
|
||
| /* size s */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
добавить бы сайзы в пикселях
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
скорее всего нужен был болд для компонента нотификейшн
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0ab0253 to
7179b15
Compare
48c6129 to
280deb9
Compare
7464624 to
eb5a6b3
Compare
eb5a6b3 to
1771142
Compare
ca842d2 to
7d632d5
Compare
7d632d5 to
c097762
Compare











No description provided.