feat/env-via-config #1955
feat/env-via-config #1955
Conversation
hextion
requested review from
SiebenSieben,
dHIM24 and
fulcanellee
as code owners
🦋 Changeset detectedLatest commit: febcc41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 78 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 19931014931Details
💛 - Coveralls |
Snapshot ReleaseSuccessfully released the following packages:
|
| export type CoreConfigContextValue = { | ||
| breakpoint: number; | ||
| client: 'desktop' | 'mobile'; | ||
| environment?: Environment; |
There was a problem hiding this comment.
Может хоть js doc какой то добавить тут? По названию понять для чего вообще эта штука нужна не возможно. Ну и в доку бы по селекту добавить что-то типа "бла-бла, в шадоу доме используйте то-то то-то"?
| export type CoreConfigContextValue = { | ||
| breakpoint: number; | ||
| client: 'desktop' | 'mobile'; | ||
| environment?: Environment; |
There was a problem hiding this comment.
example
const env: Environment | undefined = (() => {
const shadowRoot = document.querySelector('')?.shadowRoot;
if (!shadowRoot) {
return undefined;
}
return {
addEventListener: shadowRoot.addEventListener.bind(shadowRoot),
removeEventListener: shadowRoot.removeEventListener.bind(shadowRoot),
document,
Node,
}
})();
hextion
force-pushed
the
feat/env-via-config
branch
from
b5a1b16 to
febcc41
Compare
Snapshot ReleaseSuccessfully released the following packages:
|
No description provided.