Upgrade for security and performance#83
Closed
p1nox wants to merge 2 commits intocopycopter:masterfrom
Closed
Conversation
p1nox
commented
Feb 9, 2013
p1nox
commented
- Upgrading Rails version for security matters. Source: Heroku blog post "Rails Security Vulnerability" (https://blog.heroku.com/archives/2013/1/11/rails_security_vulnerability/)
- Upgrading Ruby version to 1.9.3 and beautifying of gemfile for performance matters according to the article "Speeding Up Heroku Boot Time for Rails app" (http://webcache.googleusercontent.com/search?q=cache:5XICWnTYQiMJ:devign.me/speeding-up-heroku-boot-time-for-rails-app-beating-the-error-r10-boot-timeout/+&cd=7&hl=en&ct=clnk)
- Upgrading Rails version for security matters after reading the heroku blog post "Rails Security Vulnerability" (https://blog.heroku.com/archives/2013/1/11/rails_security_vulnerability/)
- Upgrading Ruby version to 1.9.3 and beautifying of gemfile for performance matters according to the article "Speeding Up Heroku Boot Time for Rails app" (http://webcache.googleusercontent.com/search?q=cache:5XICWnTYQiMJ:devign.me/speeding-up-heroku-boot-time-for-rails-app-beating-the-error-r10-boot-timeout/+&cd=7&hl=en&ct=clnk)
|
The first commit is a duplicate for #81. |
Author
|
I linked this pull request to issue 81 beacause it was a upgrading feature, and it would be nice to upgrade to Ruby 1.9.3 and swaping jquery-rails to assets group. What can I do to fix it? Create another pull request just with changes different to the rails version on the gemfile? |
Author
|
Ok, I think that the solution here is to wait for maintainers decision, and sorry for the duplicated commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.