Fix for Redis spawning new clients for each topic/queue#21
Fix for Redis spawning new clients for each topic/queue#21sardaukar wants to merge 3 commits intocopiousfreetime:masterfrom sardaukar:master
Conversation
|
btw, couldn't get Kestrel to run locally, so didn't touch those tests |
|
Hmm, not sure why the build failed - it passes locally for me on 2.1.5, with Redis 2.8.19 |
|
Oh, I see - I wasn't using Bundler, so I have newer versions of RSpec and such... do you want to update the dependencies? |
|
I'm doing some dependency updates right now to accomodate your pull request, Looks good so far. |
|
You can ignore the travis-ci items, that's because the maildir gem now says it requires ruby 2.0 or higher and jruby has 1.8 and 1.9 modes. I've merged this pull request with #22 (basically lots of project maintenance cleanup). Check out the |
|
Oh, and add yourself to |
|
@sardaukar just making sure the redis-refactor branch works for you, I'm going to close this today and push a new qup release. |
this also includes a RSpec syntax update, I can't stand deprecation warnings :)
OK, so this fixes #20, but the behavior is not covered in tests. I'm not too well-versed in TDD, and would appreciate guidance in getting it done.
Thanks for the push to do this myself, the code is really clean and the change was real quick!