test: SIMD WASM on macOS Intel WebKit (Playwright 1.59.1)#2
Open
cooper667 wants to merge 3 commits into
Open
Conversation
Hypothesis-test PR: does the webkit-2272 SIMD JIT bug we hit on mcr.microsoft.com/playwright:v1.59.1-noble (linux/amd64) also manifest on macOS Intel? Build.sh keeps -msimd128 -mavx2 (SIMD enabled, reproduces the Linux failure). The existing .github/actions/e2e runs on ubuntu- 24.04 via the Playwright docker image and is expected to fail at the webkit project. The new check-macos-intel workflow runs on macos-13, installs Playwright natively (no docker), and exercises the same argon2 SIMD WASM against Playwright 1.59.1 webkit on Intel macOS. - bump @playwright/test to 1.59.1 (+ docker image + action digest) - add .github/workflows/check-macos-intel.yml: macos-13, native emsdk 5.0.6, native playwright install, pnpm test:e2e - build.sh left untouched (SIMD stays on)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypothesis test. PR #1 confirmed the webkit-2272 SIMD JIT bug on
mcr.microsoft.com/playwright:v1.59.1-noblelinux/amd64. Does it also affect macOS Intel webkit (same Playwright 1.59 browser release, different platform build)?Setup
build.shunchanged → SIMD WASM (-msimd128 -mavx2,src/opt.c).@playwright/testbumped to 1.59.1..github/workflows/check-macos-intel.ymlruns onmacos-13(Intel), installs emsdk 5.0.6 natively, installs playwright browsers natively (no docker), and runspnpm test:e2e.Expected signals
Results will inform whether PR #1 (drop SIMD) is sufficient, or whether we also need to warn/disable on Intel Safari clients.