Fix AWS S3 website endpoint validations#84
Open
juhazi wants to merge 2 commits intocookpad:masterfrom
Open
Conversation
added 2 commits
November 5, 2019 15:20
…-1 as valid S3 website endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in
Aws:: Route53::S3_WEBSITE_ENDPOINTSsome endpoints have a dot instead of a hyphen before the region.https://github.com/codenize-tools/roadworker/blob/7d0909cd348d2b18525e09e35326a973135495ca/lib/roadworker/route53-ext.rb#L13
This PR fixes the
dns_namevalidation to allow those endpoints as valid alias targets by adding the stray dot to the regular expression.Build does not seem to pass for any PR currently, but the change has been confirmed to work with our internal usage of roadworker