Add PrismObjectType tag to S3 objects#8
Merged
Conversation
shimpeko
force-pushed
the
sk/add-s3-object-tag
branch
3 times, most recently
from
2097dd7 to
386fd7d
Compare
shimpeko
force-pushed
the
sk/add-s3-object-tag
branch
3 times, most recently
from
76bfbb0 to
2d76f35
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds a new PrismObjectType tag to S3 objects to enable targeted lifecycle rules, and bumps various build and dependency settings.
- Introduce
createPutRequestWithTaghelper and tag uploads as live, delayed, or merged. - Migrate Gradle dependencies from
compiletoimplementation/api, upgrade Jib plugin, and bump Gradle wrapper. - Update Dockerfile to use Apache archive mirror for Hadoop downloads.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| stream/build.gradle | Upgrade Jib plugin to 3.4.5 and switch from compile to implementation. |
| shared/src/main/java/com/cookpad/prism/objectstore/PrismObjectStore.java | Add helper method for tagging and apply tags on live/delayed/merged put operations. |
| shared/build.gradle | Apply java-library plugin and change dependencies from compile to api. |
| shared/Dockerfile | Change Hadoop download URL to archive.apache.org mirror. |
| merge/build.gradle | Upgrade Jib plugin to 3.4.5 and switch from compile to implementation. |
| gradlew | Replace non‐POSIX /usr/bin/env sh startup with generated POSIX‐compliant script. |
| gradle/wrapper/gradle-wrapper.properties | Bump Gradle distribution to 7.6.4 and add networkTimeout. |
| batch/build.gradle | Upgrade Jib plugin to 3.4.5 and switch from compile to implementation. |
Comments suppressed due to low confidence (2)
shared/src/main/java/com/cookpad/prism/objectstore/PrismObjectStore.java:33
- [nitpick] Modifier ordering is inconsistent; using 'private final' is more idiomatic and improves readability.
final private AmazonS3 s3;
shared/src/main/java/com/cookpad/prism/objectstore/PrismObjectStore.java:66
- Consider adding unit tests for
createPutRequestWithTagand eachput*ObjectFilemethod to verify that the correct tags are applied.
PutObjectRequest putRequest = createPutRequestWithTag(
Member
|
Could you split this pull request into two parts, one for the build fixes and one for the tagging, so that we can easily revert the changes separately? |
shimpeko
force-pushed
the
sk/add-s3-object-tag
branch
from
2d76f35 to
99f2eb9
Compare
Contributor
Author
What: This changes add PrismObjectType tag for each object type, live/delayed/merged to S3 objects. Why: To apply S3 lifecycle rules that targets each types. For example, I'm planning to move merged objects to Amazon S3 Intelligent-Tiering storage class using lifecycle rule.
Test newly added createPutRequestWithTag() method through the putLiveObjectFile(). Updated build.gradle to resolve log4j delegation loop. ref. https://www.slf4j.org/codes.html#log4jDelegationLoop Why the delegatoin loop started to happen? Because I have added test case for method in a class which has @slf4j annotation. I'm not sure why the error doesn't occur in running application.
shimpeko
force-pushed
the
sk/add-s3-object-tag
branch
from
8c9dd91 to
c8179b6
Compare
Contributor
Author
|
@eagletmt could you take a look? |
eagletmt
approved these changes
May 21, 2025
Contributor
Author
|
thank you for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This changes add PrismObjectType tag for each object type, live/delayed/merged to S3 objects.
Why:
To apply S3 lifecycle rules that targets each types.
For example, I'm planning to move merged objects to Amazon S3 Intelligent-Tiering storage class using lifecycle rule.