Upgrade libraries to work with Java 17#11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates build/test tooling and key dependencies to support compiling and running the project on Java 17.
Changes:
- Upgrade Spring Boot Gradle plugin + dependency management plugin to Spring Boot
2.7.18in service modules. - Upgrade test/tooling dependencies (JUnit 5.8.2, Mockito 4.11.0, SpotBugs Gradle plugin 5.2.5) and adjust configuration accordingly.
- Update Mockito test API usage (
verifyZeroInteractions→verifyNoInteractions) and extend SpotBugs exclude filter.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
build.gradle |
Upgrades SpotBugs plugin and test dependencies; updates SpotBugs report configuration API for the newer plugin. |
spotbugs-exclude.xml |
Adds new SpotBugs suppression rules (EI/EI2, CT). |
stream/build.gradle |
Upgrades Spring Boot + Jackson JSR310 module; updates test autoconfigure dependency version. |
merge/build.gradle |
Upgrades Spring Boot + dependency management plugin versions. |
batch/build.gradle |
Upgrades Spring Boot + dependency management plugin versions. |
stream/src/test/java/com/cookpad/prism/stream/events/StagingObjectDispatcherTest.java |
Updates Mockito verification call to the modern API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+14
| implementation group: 'org.springframework.boot', name: 'spring-boot-starter', version: '2.7.18' | ||
| implementation group: 'org.springframework.boot', name: 'spring-boot-starter-logging', version: '2.7.18' | ||
| implementation group: 'com.fasterxml.jackson.datatype', name: 'jackson-datatype-jsr310', version: '2.14.2' | ||
| implementation group: 'io.sentry', name: 'sentry-logback', version: '1.7.30' | ||
| implementation group: 'org.postgresql', name: 'postgresql', version: '42.2.5' | ||
| testImplementation group: 'org.springframework.boot', name: 'spring-boot-test-autoconfigure', version: '2.1.3.RELEASE' | ||
| testImplementation group: 'org.springframework.boot', name: 'spring-boot-test-autoconfigure', version: '2.7.18' |
Comment on lines
+8
to
+13
| <Match> | ||
| <Bug code="EI,EI2" /> | ||
| </Match> | ||
| <Match> | ||
| <Bug code="CT" /> | ||
| </Match> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.