Fix: Adjust pagination metadata when fetching projects with an assignee filter#18
Merged
Fix: Adjust pagination metadata when fetching projects with an assignee filter#18
Conversation
welias
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a pagination bug in the
projects listcommand. Previously, when using filters that required fetching all pages and processing them locally (e.g., filtering byassignee), the command still parsed the raw API metadata fortotalPagesandtotalCount. This led to a misleading summary indicating many pages (like "Page 1/36") even when the local filtering only returned a handful of results that fit completely on a single page.The output logic has been updated so that when
fetch_allis triggered, the displayed "total pages" and "total items" are correctly calculated from the localized result set.How to Test
python -m conviso.app projects list --company-id <ID> --filter assignee=<EMAIL>.page 1/1rather than retaining the unfiltered total counts from the initial API metadata.