Fix errors #221
Merged
Fix errors #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
f3l1x
commented
Nov 30, 2025
f3l1x
commented
- Add proper type hints for enum arrays in RequestParameter, EndpointParameter
- Update ITypeMapper interface to support optional enumValues parameter
- Update all ITypeMapper implementations with the new signature
- Fix EnumTypeMapper to handle null enumValues and use strict in_array
- Add type hints for groups in SymfonyValidator
- Fix ArrayEntity::from() return type annotation
- Fix spacing after if statement in EntityAdapter
f3l1x
force-pushed
the
claude/run-qa-tools-fix-errors-01BRaUbLrqG23kW8bksFVhRz
branch
2 times, most recently
from
c734164 to
5acec7f
Compare
- Fix StringTypeMapperTest to not pass extra argument - Add enum key to expected output in ArraySerializator test - Handle missing enum key in ArrayHydrator - Fix fputcsv deprecation in CsvTransformer for PHP 8.4
- Add 2nd parameter array \$options = [] to ITypeMapper::normalize() - Update all type mapper implementations with @inheritdoc - Make EnumTypeMapper implement ITypeMapper interface - Pass EndpointParameter via options['endpoint'] in RequestParameterMapping - Remove enum values from exception message for cleaner output
- Add type hints for enum arrays in RequestParameter and EndpointParameter - Add type hints for groups array in SymfonyValidator - Fix return type in ArrayEntity::getData() - Fix EntityAdapter spacing issue
f3l1x
force-pushed
the
claude/run-qa-tools-fix-errors-01BRaUbLrqG23kW8bksFVhRz
branch
from
5acec7f to
c15308d
Compare
Remove calls to setAccessible() as it has no effect since PHP 8.5 and properties are accessible by default through reflection.
f3l1x
deleted the
claude/run-qa-tools-fix-errors-01BRaUbLrqG23kW8bksFVhRz
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.