refactor: unify AbortError detection with isAbortError utility#10551
Open
amabito wants to merge 1 commit intocontinuedev:mainfrom
Open
refactor: unify AbortError detection with isAbortError utility#10551amabito wants to merge 1 commit intocontinuedev:mainfrom
amabito wants to merge 1 commit intocontinuedev:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
AbortError detection was scattered across 3+ patterns (string comparison, .name check, .code check). Consolidates into a single isAbortError() utility that handles all known patterns: "cancel" string, DOMException, Error.name variants, ABORT_ERR code, and plain objects. Updates call sites in core/llm/index.ts and core/llm/utils/retry.ts.
be768d5 to
ab9267b
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Heads up: the only failure appears to be a flaky GUI e2e check ( A rerun of the failing job should unblock merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name.includes,name.startsWith,=== "cancel",code === "ABORT_ERR")isAbortError(error)utility and replaces inline checksChanges
core/util/isAbortError.ts(new) — unified abort detection covering all known patternscore/util/isAbortError.test.ts(new) — 14 test cases (positive + negative)core/llm/index.ts— replaced 2 inline abort checks withisAbortError()core/llm/utils/retry.ts— replaced 1 inline abort check withisAbortError()Semantics preserved
includes("AbortError")to match the original behavior at all replacement sites"cancel"andcode="ABORT_ERR"errors from console logging (these are all abort cases that should not pollute the console)Test plan
isAbortError.test.tspasses (14 cases)core/llm/index.test.tsstill passes🤖 Generated with Claude Code
Continue Tasks: ✅ 1 no changes — View all
Summary by cubic
Unifies abort error detection with a shared isAbortError utility across LLM core to keep handling consistent and cut noisy abort logs. No behavior change for end users.
Written for commit ab9267b. Summary will update on new commits.