Feat/delta aem#1092
Open
umesh-more-cstk wants to merge 6 commits into
Open
Conversation
…nd mapping integration
# Conflicts: # ui/src/components/ContentMapper/index.tsx
- api: add unit tests for the delta Asset Mapper decision branches (isUpdate reuse vs in-place update), saveAssetMetadata/ loadPreviousAssetMetadata, ensureUpdateConfigFile/ enrichConfigWithAssetUpdates, and the entry-update-script.cjs helpers (isAssetField, resolveAssetField 3-way, mergeFlatPayloadIntoEntry, task runner). Expose the cjs helpers for testing. - api: fix stale contentMapper.routes mock (add getAssetMapping, getSingleContentTypes, getSingleGlobalField, updateAssetStatus) and uid-mapper assertion to match the current always-write behavior. - upload-api: add extractEntries/extractAssets to the migration-aem mock in aem.controller.test so createAemMapper makes both API calls.
…fix EntryMapper wiring - Extract pure logic from assetMapper.tsx and entryMapper.tsx into assetMapper.utils.ts / entryMapper.utils.ts (row mapping, selection build/apply, changed-uid diff, content-type status filtering) and add unit tests for both. - Fix two pre-existing bugs in the delta EntryMapper render in index.tsx: reference the existing isDeltaIteration flag instead of an undefined 'iteration' variable, and pass the required handleStepChange prop instead of tableHeight/selectedContentTypeId (which EntryMapper ignores).
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
Consider reviewing these vulnerabilities when fixes become available. |
Add a removeExistingAssets test that drives the entry-JSON reference rewrite path (entriesDir present -> content-type/locale/chunk walk -> replaceAssetRefsInObject). This covers the four previously-uncovered functions in asset-update.utils.ts, raising api function coverage from 79.9% to 80.82% (above the 80% CI threshold).
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
Consider reviewing these vulnerabilities when fixes become available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira Ticket
MIGRATION-XXXX
📋 PR Type
📝 Description
What changed?
Why?
🧩 Affected Areas
api— Node.js backendui— React frontendupload-api— Upload API serverdocker/docker-compose🧪 How to Test
Expected result:
📸 Screenshots / Recordings
🔗 Related PRs / Dependencies
✅ Author Checklist
feature/,bugfix/, orhotfix/+ 5–30 lowercase chars.env/example.envupdated if new environment variables were addednpm test)README.md/ docs updated if behaviour changed👀 Reviewer Notes